[DX-4010] Discover Flakes in CI#22384
Conversation
product-security-plaid-production
Bot
requested review from
chainchad,
gustavogama-cll and
prashantkumar1982
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — introduces a scheduled CI workflow that can consume significant compute resources and needs to behave correctly on both schedule and workflow_dispatch triggers.
Adds a new GitHub Actions workflow to run the tools/test diagnose harness regularly in CI and upload the generated diagnose-* reports as artifacts.
Changes:
- Introduces
.github/workflows/find-flaky-tests.ymlscheduled (daily) and manually-dispatchable workflow. - Runs
go -C tools/test run . diagnose ...with configurable iteration parameters. - Uploads
diagnose-*outputs as a workflow artifact for later analysis/automation.
Targeted areas for scrupulous human review:
- The
scheduletrigger path: ensure parameter defaults are applied wheninputs.*is unavailable. - The Go package pattern argument (
dir) defaults/format: ensure it matchesgo testexpectations (e.g.,./core/...) to avoid immediate failures on CI.
Run the
diagnosecommand in CI regularly, generating reports that AI agents can act on.